Skip to content

Conversation

@caph1993
Copy link
Contributor

@caph1993 caph1993 commented Aug 13, 2025

There is a missing parenthesis in the documentation of the function MASE.

Current: (y_pred - target).abs() /  all_targets[:, :-1] - all_targets[:, 1:]).mean(1)
                                   ^
                                   |
                                   v
Correct: (y_pred - target).abs() / (all_targets[:, :-1] - all_targets[:, 1:]).mean(1)

Reference Issues/PRs

NA — Too simple to create an issue, I think.

What does this implement/fix? Explain your changes.

This commit adds the missing parenthesis.

What should a reviewer concentrate their feedback on?

NA

Did you add any tests for the change?

NA

Any other comments?

NA

PR checklist

  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.

There is a missing parenthesis in the definition. This commit fixes that
@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@f87bb56). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1944   +/-   ##
=======================================
  Coverage        ?   87.07%           
=======================================
  Files           ?      136           
  Lines           ?     8624           
  Branches        ?        0           
=======================================
  Hits            ?     7509           
  Misses          ?     1115           
  Partials        ?        0           
Flag Coverage Δ
cpu 87.07% <ø> (?)
pytest 87.07% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fkiraly fkiraly merged commit 1956bc8 into sktime:main Aug 16, 2025
35 checks passed
@caph1993 caph1993 deleted the patch-1 branch August 16, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants