[BUG] fixed memory leak in BaseModel by detach some tensor #1924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zju-ys
requested review from
benHeid,
fkiraly,
fnhirwa,
jdb78 and
yarnabrina
as code owners
zju-ys
force-pushed
the
main
branch
4 times, most recently
from
f1d90ca to
ef47701
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1924 +/- ##
=======================================
Coverage ? 87.03%
=======================================
Files ? 101
Lines ? 8077
Branches ? 0
=======================================
Hits ? 7030
Misses ? 1047
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zju-ys
force-pushed
the
main
branch
10 times, most recently
from
9541569 to
ab2eb8d
Compare
github-project-automation
bot
moved this to Fixed/resolved
in Bugfixing - pytorch-forecasting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#1369
#1461
What does this implement/fix? Explain your changes.
1.Detached tensors in the log dictionary before appending them to the training/validation/testing_step_outputs lists. This fixes a memory leak caused by retaining the computation graph for every batch throughout an entire epoch.
2.Detached the loss tensor within the step() method before logging.
3.Move prediction results to CPU to prevent VRAM growth.
Did you add any tests for the change?
I ran my training code for 5 epochs using a memory profiler. Here are two comparison plot:
before
after