Skip to content

Conversation

@Pinaka07
Copy link
Contributor

@Pinaka07 Pinaka07 commented Jul 9, 2025

Reference Issues/PRs

fixes #1881

What does this implement/fix? Explain your changes.

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

Any other comments?

PR checklist

  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

@Pinaka07
Copy link
Contributor Author

Pinaka07 commented Jul 9, 2025

"If the time series denote different entities or exhibit very similar patterns accross the board, a model such as N-BEATS will not work as well."

This might be slightly misleading — N-BEATS is actually designed to work well when time series are from different entities but share similar patterns, as it learns global structures across series.

It typically struggles when the time series are from different entities and exhibit highly diverse or uncorrelated patterns.

Consider rephrasing to:
"If the timeseries denote different entities or exhibit very similar patterns across the board, a model such as N-Beats will not work as well."

@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@b8dbacc). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1914   +/-   ##
=======================================
  Coverage        ?   86.33%           
=======================================
  Files           ?       96           
  Lines           ?     7802           
  Branches        ?        0           
=======================================
  Hits            ?     6736           
  Misses          ?     1066           
  Partials        ?        0           
Flag Coverage Δ
cpu 86.33% <ø> (?)
pytest 86.33% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pinaka07 Pinaka07 changed the title solved issue #1881 [DOC] solved issue #1881 Jul 9, 2025
@fnhirwa fnhirwa changed the title [DOC] solved issue #1881 [DOC] Correct documentation for N-BEATS Jul 10, 2025
Copy link
Member

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me😊

@fnhirwa fnhirwa merged commit b59495d into sktime:main Jul 10, 2025
35 checks passed
@Pinaka07
Copy link
Contributor Author

Thanks @fnhirwa 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] I think the doc is incorrect in a misleading way - need to confirm

2 participants