Skip to content

[BUG] fix incorrect concatenation dimension in concat_sequences #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fkiraly merged 7 commits into from
May 16, 2025
Merged

[BUG] fix incorrect concatenation dimension in concat_sequences #1827

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c107d37
PR for issue 1823
cngmid May 8, 2025
a9d8fa3
excluding python 3.13 from test and comment nunpy __array_wrap__ warning
cngmid May 8, 2025
e0d620e
reverting changes to test.yml and pytest.ini
cngmid May 9, 2025
21ee218
Added test for modified functionality
cngmid May 15, 2025
5fe1fca
Merge branch 'main' into issue_1823
cngmid May 15, 2025
3722a04
lint
fkiraly May 15, 2025
890d264
linting
fkiraly May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
python-version: ["3.9", "3.10", "3.11", "3.12"]

steps:
- uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,4 @@ filterwarnings =
ignore:The dataloader, [\_\s]+ \d+, does not have many workers which may be a bottleneck.:UserWarning
ignore:Consider increasing the value of the `num_workers` argument`:UserWarning
ignore::UserWarning
ignore:__array_wrap__ must accept context
2 changes: 1 addition & 1 deletion pytorch_forecasting/utils/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def concat_sequences(
if isinstance(sequences[0], rnn.PackedSequence):
return rnn.pack_sequence(sequences, enforce_sorted=False)
elif isinstance(sequences[0], torch.Tensor):
return torch.cat(sequences, dim=1)
return torch.cat(sequences, dim=0)
elif isinstance(sequences[0], (tuple, list)):
return tuple(
concat_sequences([sequences[ii][i] for ii in range(len(sequences))])
Expand Down
Loading