Skip to content

bugfix: Mobile hover styles#4283

Merged
endigo9740 merged 5 commits intoskeletonlabs:mainfrom
cmintey:bugfix/mobile-hover-styles
Feb 24, 2026
Merged

bugfix: Mobile hover styles#4283
endigo9740 merged 5 commits intoskeletonlabs:mainfrom
cmintey:bugfix/mobile-hover-styles

Conversation

@cmintey
Copy link
Contributor

@cmintey cmintey commented Feb 19, 2026

Linked Issue

Discussed in #4281

Description

As discussed in the discussion, there is an issue with "sticky" hover states for buttons and some components due to not using tailwind's @variant directive. This PR implements the usage of that directive for all styles that have a hover state.

In addition, the webkit tap style was updated to use the surface color instead of the primary color (this was discussed on Discord).

Finally, added an "active" state for buttons to scale to 95% to give the illusion of a real button depress. This style was included in Skeleton v2.

If the scope of this PR is too broad, let me know. Happy to move some elements to another PR or remove them entirely.

AI Disclosure

Use of LLM technology is allowed. We ask for your voluntary disclosure to help inform future Skeleton contribution guidelines.

  • I used AI to generate this pull request

Checklist

Please read and apply all contribution requirements.

  • Your branch should be prefixed with: docs/, feature/, task/, bugfix/
  • Contributions should target the main branch
  • Documentation should be updated to describe all relevant changes
  • Run pnpm check in the root of the monorepo
  • Run pnpm format in the root of the monorepo
  • Run pnpm lint in the root of the monorepo
  • Run pnpm test in the root of the monorepo
  • If you modify /package projects, please supply a Changeset

Changesets

View our documentation to learn more about Changesets. To create a Changeset:

  1. Navigate to the root of the monorepo in your terminal
  2. Run pnpm changeset and follow the prompts
  3. Commit and push the changeset before flagging your PR ready for review.

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2026

🦋 Changeset detected

Latest commit: 8703786

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@skeletonlabs/skeleton-common Patch
@skeletonlabs/skeleton Patch
@skeletonlabs/skeleton-react Patch
@skeletonlabs/skeleton-svelte Patch
skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
www.skeleton.dev Ready Ready Preview Feb 24, 2026 2:41am

Request Review

@endigo9740
Copy link
Contributor

endigo9740 commented Feb 20, 2026

Hey @cmintey I think all the updates are great except for this one:

Finally, added an "active" state for buttons to scale to 95% to give the illusion of a real button depress. This style was included in Skeleton v2.

This was actually very intentionally removed in the v3 transition. It's a very opinionated style, which is better suited for users to implement locally via a style override the btn classes.

So if you can revert that I think everything else should be good to go. I'll do one more final sweep to confirm.

Copy link
Contributor

@endigo9740 endigo9740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @cmintey

@endigo9740 endigo9740 merged commit 4ec9097 into skeletonlabs:main Feb 24, 2026
6 checks passed
@github-actions github-actions bot mentioned this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants