bugfix: Mobile hover styles#4283
Conversation
🦋 Changeset detectedLatest commit: 8703786 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Hey @cmintey I think all the updates are great except for this one:
This was actually very intentionally removed in the v3 transition. It's a very opinionated style, which is better suited for users to implement locally via a style override the So if you can revert that I think everything else should be good to go. I'll do one more final sweep to confirm. |
endigo9740
left a comment
There was a problem hiding this comment.
This looks great, thanks @cmintey
Linked Issue
Discussed in #4281
Description
As discussed in the discussion, there is an issue with "sticky" hover states for buttons and some components due to not using tailwind's
@variantdirective. This PR implements the usage of that directive for all styles that have a hover state.In addition, the webkit tap style was updated to use the surface color instead of the primary color (this was discussed on Discord).
Finally, added an "active" state for buttons to scale to 95% to give the illusion of a real button depress. This style was included in Skeleton v2.If the scope of this PR is too broad, let me know. Happy to move some elements to another PR or remove them entirely.
AI Disclosure
Use of LLM technology is allowed. We ask for your voluntary disclosure to help inform future Skeleton contribution guidelines.
Checklist
Please read and apply all contribution requirements.
docs/,feature/,task/,bugfix/mainbranchpnpm checkin the root of the monorepopnpm formatin the root of the monorepopnpm lintin the root of the monorepopnpm testin the root of the monorepo/packageprojects, please supply a ChangesetChangesets
View our documentation to learn more about Changesets. To create a Changeset:
pnpm changesetand follow the prompts