agent: retry transient LLM failures in loop#857
agent: retry transient LLM failures in loop#857pikaxinge wants to merge 1 commit intosipeed:mainfrom
Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }) | ||
| } | ||
|
|
||
| if retry < len(transientBackoff) { |
There was a problem hiding this comment.
therre have two kinds retry?
- time out、502/503、connection reset、TLS -> backoff retry ?
- contains(token/context/invalidparameter/length) -> compression retry?
nikolasdehor
left a comment
There was a problem hiding this comment.
This PR is superseded by #866, which extracts the retry logic into a shared pkg/utils/llm_retry.go engine and addresses the reviewer feedback from #594 (parent deadline capping, Retry-After parsing, jittered backoff, toolloop integration).
The core changes here (transient retry in agent loop, isTransientLLMError, isContextWindowError) are all present in #866 in a more complete form.
Recommend closing this in favor of #866.
Summary
Test Plan
Fixes #629