feat(discord): add proxy support and tests#853
Merged
alexhoshina merged 3 commits intosipeed:mainfrom Mar 3, 2026
Merged
Conversation
nayihz
force-pushed
the
feat_discord_proxy
branch
from
3414a32 to
b5a4bb2
Compare
Contributor
Author
|
@alexhoshina Could you help review this PR? Thanks. |
alexhoshina
reviewed
Mar 2, 2026
Collaborator
There was a problem hiding this comment.
Should be moved to pkg/channels/discord/discord_test.go
pkg/channels/discord/discord.go
Outdated
|
|
||
| transport := &http.Transport{Proxy: proxyFunc} | ||
| session.Client = &http.Client{ | ||
| Timeout: 20 * time.Second, |
Collaborator
There was a problem hiding this comment.
Perhaps the hardcoded values could be extracted as constants or configuration
nayihz
force-pushed
the
feat_discord_proxy
branch
from
fea9433 to
76bdab9
Compare
Zhaoyikaiii
reviewed
Mar 3, 2026
nayihz
force-pushed
the
feat_discord_proxy
branch
2 times, most recently
from
dd0013d to
c7a5881
Compare
nayihz
force-pushed
the
feat_discord_proxy
branch
from
c7a5881 to
69b1ae4
Compare
hyperwd
pushed a commit
to hyperwd/picoclaw
that referenced
this pull request
Mar 5, 2026
feat(discord): add proxy support and tests
Pluckypan
pushed a commit
to Pluckypan/picoclaw
that referenced
this pull request
Mar 6, 2026
feat(discord): add proxy support and tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Add Discord proxy support for both REST and websocket paths, with coverage tests. This ensures Discord can work in proxied environments when a channel proxy is configured (including
socks5://) and improves behavior around proxy setup validation.🗣️ Type of Change
🤖 AI Code Generation
🔗 Related Issue
N/A
📚 Technical Context (Skip for Docs)
🧪 Test Environment
📸 Evidence (Optional)
Click to view Logs/Screenshots
Added
pkg/channels/discord_test.goand validated proxy setup behavior via unit tests.☑️ Checklist