Skip to content

fix(heartbeat): resolve bug where service could never start #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lxowalle merged 1 commit into from
Feb 12, 2026
Merged

fix(heartbeat): resolve bug where service could never start #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkg/heartbeat/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ type HeartbeatService struct {
interval time.Duration
enabled bool
mu sync.RWMutex
started bool
stopChan chan struct{}
}

Expand All @@ -31,14 +32,15 @@ func (hs *HeartbeatService) Start() error {
hs.mu.Lock()
defer hs.mu.Unlock()

if hs.running() {
if hs.started {
return nil
}

if !hs.enabled {
return fmt.Errorf("heartbeat service is disabled")
}

hs.started = true
go hs.runLoop()

return nil
Expand All @@ -48,10 +50,11 @@ func (hs *HeartbeatService) Stop() {
hs.mu.Lock()
defer hs.mu.Unlock()

if !hs.running() {
if !hs.started {
return
}

hs.started = false
close(hs.stopChan)
}

Expand Down