Skip to content

config: add baidu_search example to config.example.json #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lxowalle merged 1 commit into from
Mar 25, 2026
Merged

config: add baidu_search example to config.example.json #1990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions config/config.example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,12 @@
"search_engine": "search_std",
"max_results": 5
},
"baidu_search": {
"enabled": false,
"api_key": "",
"base_url": "https://qianfan.baidubce.com/v2/ai_search/web_search",
"max_results": 10
},
Comment on lines +289 to +294
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.example.json does not include a version field, so LoadConfig will treat it as legacy v0 and run loadConfigV0 migration. The v0 schema currently doesn’t include baidu_search, so this example block will be ignored during migration; consider adding the current version to the example, or updating the v0 migration structs to include baidu_search so the example actually takes effect.

Copilot uses AI. Check for mistakes.
"fetch_limit_bytes": 10485760,
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added baidu_search object is missing a trailing comma after the closing }. As written, the JSON is invalid because the next sibling key (fetch_limit_bytes) follows immediately.

Suggested change
"fetch_limit_bytes": 10485760,

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Within tools.web, fetch_limit_bytes appears twice (once earlier in the object and again here). Duplicate keys are ambiguous in JSON and can lead to confusing “last one wins” behavior; remove one of the entries to keep the example unambiguous.

Suggested change
"fetch_limit_bytes": 10485760,

Copilot uses AI. Check for mistakes.
"private_host_whitelist": []
},
Expand Down
Loading