Skip to content

refactor: remove redundant Darwin tray stub#1694

Merged
wj-xiao merged 1 commit intosipeed:mainfrom
wj-xiao:fix/remove_redundant_tray
Mar 17, 2026
Merged

refactor: remove redundant Darwin tray stub#1694
wj-xiao merged 1 commit intosipeed:mainfrom
wj-xiao:fix/remove_redundant_tray

Conversation

@wj-xiao
Copy link
Collaborator

@wj-xiao wj-xiao commented Mar 17, 2026

📝 Description

Remove the redundant Darwin-specific no-cgo tray stub and rely on the shared no-cgo tray fallback implementation in web/backend/tray_stub_nocgo.go.

This keeps the no-cgo tray behavior in a single place and avoids maintaining duplicate fallback code for Darwin.

Checks were intentionally skipped before opening this PR, per request.

🗣️ Type of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 📖 Documentation update
  • ⚡ Code refactoring (no functional changes, no api changes)

🤖 AI Code Generation

  • 🤖 Fully AI-generated (100% AI, 0% Human)
  • 🛠️ Mostly AI-generated (AI draft, Human verified/modified)
  • 👨‍💻 Mostly Human-written (Human lead, AI assisted or none)

🔗 Related Issue

N/A

📚 Technical Context (Skip for Docs)

  • Reference URL: N/A
  • Reasoning: web/backend/tray_stub_nocgo.go already covers (darwin || freebsd) && !cgo, so the separate Darwin-only stub is redundant.

🧪 Test Environment

  • Hardware: N/A (checks skipped per request)
  • OS: macOS (not runtime-tested)
  • Model/Provider: N/A
  • Channels: N/A

📸 Evidence (Optional)

Click to view Logs/Screenshots

No additional logs or screenshots for this cleanup.

☑️ Checklist

  • My code/docs follow the style of this project.
  • I have performed a self-review of my own changes.
  • I have updated the documentation accordingly.

@wj-xiao wj-xiao merged commit 12c0132 into sipeed:main Mar 17, 2026
4 checks passed
dome pushed a commit to domeclaw/domeclaw that referenced this pull request Mar 17, 2026
j0904 pushed a commit to j0904/picoclaw that referenced this pull request Mar 22, 2026
@wj-xiao wj-xiao deleted the fix/remove_redundant_tray branch March 23, 2026 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants