Skip to content

feat(web): add configurable cron command execution settings#1647

Merged
wj-xiao merged 1 commit intosipeed:mainfrom
wj-xiao:feat/cron-config
Mar 17, 2026
Merged

feat(web): add configurable cron command execution settings#1647
wj-xiao merged 1 commit intosipeed:mainfrom
wj-xiao:feat/cron-config

Conversation

@wj-xiao
Copy link
Collaborator

@wj-xiao wj-xiao commented Mar 16, 2026

📝 Description

This PR makes cron command execution configurable from both the backend config and the web config UI.

  • add tools.cron.allow_command with a default value of true to preserve existing behavior
  • require command_confirm=true only when cron command execution is explicitly disabled
  • expose cron shell execution permission and timeout settings in the config page
  • add config and cron tool tests for the new behavior

🗣️ Type of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 📖 Documentation update
  • ⚡ Code refactoring (no functional changes, no api changes)

🤖 AI Code Generation

  • 🤖 Fully AI-generated (100% AI, 0% Human)
  • 🛠️ Mostly AI-generated (AI draft, Human verified/modified)
  • 👨‍💻 Mostly Human-written (Human lead, AI assisted or none)

🔗 Related Issue

N/A

📚 Technical Context (Skip for Docs)

  • Reference URL: N/A
  • Reasoning: Cron command scheduling is already restricted to internal channels. This change adds an explicit config gate for scheduled shell commands, keeps the default backward-compatible, and exposes the related controls in the web UI so operators can disable command scheduling without changing code.

🧪 Test Environment

  • Hardware: Apple Silicon Mac / local development machine
  • OS: macOS
  • Model/Provider: N/A (config and tool behavior verified with automated tests)
  • Channels: CLI / internal channel test cases

📸 Evidence (Optional)

Click to view Logs/Screenshots

make check

☑️ Checklist

  • My code/docs follow the style of this project.
  • I have performed a self-review of my own changes.
  • I have updated the documentation accordingly.

- add tools.cron.allow_command config with a default value of true
- require command_confirm only when cron command execution is disabled
- expose cron command permission and timeout settings in the config UI
- add backend tests and update i18n strings
@sipeed-bot sipeed-bot bot added type: enhancement New feature or request domain: config domain: tool go Pull requests that update go code labels Mar 16, 2026
@wj-xiao wj-xiao merged commit fcb6986 into sipeed:main Mar 17, 2026
4 checks passed
alexhoshina pushed a commit to alexhoshina/picoclaw that referenced this pull request Mar 17, 2026
)

- add tools.cron.allow_command config with a default value of true
- require command_confirm only when cron command execution is disabled
- expose cron command permission and timeout settings in the config UI
- add backend tests and update i18n strings
j0904 pushed a commit to j0904/picoclaw that referenced this pull request Mar 22, 2026
)

- add tools.cron.allow_command config with a default value of true
- require command_confirm only when cron command execution is disabled
- expose cron command permission and timeout settings in the config UI
- add backend tests and update i18n strings
@wj-xiao wj-xiao deleted the feat/cron-config branch March 23, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: config domain: tool go Pull requests that update go code type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants