Closed
Conversation
xuwei-xy
pushed a commit
to xuwei-xy/picoclaw
that referenced
this pull request
Mar 14, 2026
Contributor
Author
|
Closing this to reduce duplicate PRs in the queue. After re-checking issue #1044 and the current open PRs, this branch overlaps with existing open timezone-fix lines, especially #1046 and #1092. The change itself is reasonable, but keeping a third open PR on the same If the other timezone PRs stall out and maintainers want this exact patch instead, it can be reopened from here or recreated cleanly on top of current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Honor
schedule.tzwhen computing the next run time for cron expressions so scheduled jobs execute in the intended timezone instead of always following the process default timezone.🗣️ Type of Change
🤖 AI Code Generation
🔗 Related Issue
Fixes #1044
📚 Technical Context (Skip for Docs)
computeNextRun()now loadsschedule.TZ, evaluates the cron expression in that location, and keeps the existing baseline behavior when the timezone is empty or invalid.🧪 Test Environment
📸 Evidence (Optional)
Click to view Logs/Screenshots
go test ./pkg/cron -run 'Test(SaveStore_FilePermissions|ComputeNextRun_UsesScheduleTimeZone)' -count=1☑️ Checklist