Skip to content

fix(cron): honor schedule time zones#1444

Closed
Alix-007 wants to merge 1 commit intosipeed:mainfrom
Alix-007:pr/issue-1044-cron-timezone
Closed

fix(cron): honor schedule time zones#1444
Alix-007 wants to merge 1 commit intosipeed:mainfrom
Alix-007:pr/issue-1044-cron-timezone

Conversation

@Alix-007
Copy link
Contributor

📝 Description

Honor schedule.tz when computing the next run time for cron expressions so scheduled jobs execute in the intended timezone instead of always following the process default timezone.

🗣️ Type of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 📖 Documentation update
  • ⚡ Code refactoring (no functional changes, no api changes)

🤖 AI Code Generation

  • 🤖 Fully AI-generated (100% AI, 0% Human)
  • 🛠️ Mostly AI-generated (AI draft, Human verified/modified)
  • 👨‍💻 Mostly Human-written (Human lead, AI assisted or none)

🔗 Related Issue

Fixes #1044

📚 Technical Context (Skip for Docs)

🧪 Test Environment

  • Hardware: PC
  • OS: Windows 11
  • Model/Provider: N/A
  • Channels: N/A

📸 Evidence (Optional)

Click to view Logs/Screenshots
  • go test ./pkg/cron -run 'Test(SaveStore_FilePermissions|ComputeNextRun_UsesScheduleTimeZone)' -count=1

☑️ Checklist

  • My code/docs follow the style of this project.
  • I have performed a self-review of my own changes.
  • I have updated the documentation accordingly.

@sipeed-bot sipeed-bot bot added type: bug Something isn't working domain: corn go Pull requests that update go code labels Mar 12, 2026
xuwei-xy pushed a commit to xuwei-xy/picoclaw that referenced this pull request Mar 14, 2026
@Alix-007
Copy link
Contributor Author

Closing this to reduce duplicate PRs in the queue.

After re-checking issue #1044 and the current open PRs, this branch overlaps with existing open timezone-fix lines, especially #1046 and #1092.

The change itself is reasonable, but keeping a third open PR on the same schedule.TZ bug does not add much review value. It is better to let the maintainers choose among the already-open lines instead of continuing to maintain another duplicate branch.

If the other timezone PRs stall out and maintainers want this exact patch instead, it can be reopened from here or recreated cleanly on top of current main.

@Alix-007 Alix-007 closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: corn go Pull requests that update go code type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Cron expressions ignore schedule.TZ field, always evaluate in UTC

1 participant