Skip to content

fix(channels): stop stale typing loops on overwrite#1392

Merged
alexhoshina merged 1 commit intosipeed:mainfrom
Alix-007:fix/issue-1323-stop-old-typing
Mar 12, 2026
Merged

fix(channels): stop stale typing loops on overwrite#1392
alexhoshina merged 1 commit intosipeed:mainfrom
Alix-007:fix/issue-1323-stop-old-typing

Conversation

@Alix-007
Copy link
Contributor

Summary

  • stop the previous typing loop immediately when the same channel/chat registers a replacement stop function
  • keep the replacement stop callback active until the response is sent
  • add a regression test for repeated typing registration on the same chat

Testing

  • go test ./pkg/channels -run ''Test(PreSend_TypingStopCalled|RecordTypingStop|TypingStopJanitorEviction)''

Fixes #1323
Fixes #1212

@sipeed-bot sipeed-bot bot added type: bug Something isn't working domain: channel go Pull requests that update go code labels Mar 12, 2026
@alexhoshina alexhoshina merged commit 3bcbfd9 into sipeed:main Mar 12, 2026
4 checks passed
neotty pushed a commit to neotty/picoclaw that referenced this pull request Mar 12, 2026
dj-oyu pushed a commit to dj-oyu/picoclaw that referenced this pull request Mar 14, 2026
dj-oyu pushed a commit to dj-oyu/picoclaw that referenced this pull request Mar 16, 2026
j0904 pushed a commit to j0904/picoclaw that referenced this pull request Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: channel go Pull requests that update go code type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Endless sending of "typing" message telegram. [BUG] 同时在telegram发送多条消息后,telegram一直显示“正在输入...”

2 participants