fix: spawn tool now respects target agent's model config#1356
Closed
treepudding wants to merge 1 commit intosipeed:mainfrom
Closed
fix: spawn tool now respects target agent's model config#1356treepudding wants to merge 1 commit intosipeed:mainfrom
treepudding wants to merge 1 commit intosipeed:mainfrom
Conversation
|
|
sipeed-bot
bot
added
type: bug
Fixes sipeed#1322 Previously, when spawn tool was called with agent_id parameter, the subagent would use the caller agent's model instead of the target agent's configured model. Changes: - Add modelResolver field to SubagentManager - Add SetModelResolver() method to inject model resolution function - In runTask(), use target agent's model when agent_id is specified - Add test case for model resolver functionality Test Plan: - All existing tests pass - New TestSubagentManager_ModelResolver test passes
treepudding
force-pushed
the
fix/spawn-model-resolver
branch
from
a21f7a9 to
cdbd09b
Compare
Contributor
|
Cherry-picked cleanly. The fix ensures subagents spawned with |
Author
|
@alexhoshina Hi,this PR is waiting for CI approval. Could you please approve the workflow run? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1322
Previously, when
spawntool was called withagent_idparameter, the subagent would use the caller agent's model instead of the target agent's configured model.Changes
modelResolverfield toSubagentManagerSetModelResolver()method to inject model resolution functionrunTask(), use target agent's model whenagent_idis specifiedTest Plan
go test ./pkg/tools/... ./pkg/agent/...)TestSubagentManager_ModelResolvertest passesgo build ./...)