Enhance model selection and add footer navigation instructions by taorye · Pull Request #1271 · sipeed/picoclaw

taorye · 2026-03-09T10:13:09Z

📝 Description

🗣️ Type of Change

🐞 Bug fix (non-breaking change which fixes an issue)
✨ New feature (non-breaking change which adds functionality)
📖 Documentation update
⚡ Code refactoring (no functional changes, no api changes)

🤖 AI Code Generation

🤖 Fully AI-generated (100% AI, 0% Human)
🛠️ Mostly AI-generated (AI draft, Human verified/modified)
👨‍💻 Mostly Human-written (Human lead, AI assisted or none)

🔗 Related Issue

📚 Technical Context (Skip for Docs)

Reference URL:
Reasoning:

🧪 Test Environment

Hardware: PC(x86_64)
OS: Arch
Model/Provider: openai/gpt-5.4
Channels: Telegram

📸 Evidence (Optional)

Click to view Logs/Screenshots

☑️ Checklist

My code/docs follow the style of this project.
I have performed a self-review of my own changes.
I have updated the documentation accordingly.

… model form button highlight

…nu structure

CLAassistant · 2026-03-09T10:14:13Z

All committers have signed the CLA.

Copilot

Pull request overview

This PR updates the launcher TUI to improve navigation clarity (via a persistent footer) and refines model/channel selection behavior in the configuration menus.

Changes:

Adds a footer bar with keyboard navigation hints to the TUI layout.
Adjusts model menu behavior (row indexing, add-model entry placement, delete confirmation) and adds model-name validation.
Updates the main menu channel entry to show an enabled/total channel count.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File	Description
cmd/picoclaw-launcher-tui/internal/ui/style.go	Adds a centered footer TextView with navigation instructions.
cmd/picoclaw-launcher-tui/internal/ui/app.go	Integrates the footer into the root layout and shows enabled/total channel counts on the main menu.
cmd/picoclaw-launcher-tui/internal/ui/model.go	Reworks model menu item ordering/indexing, adds add-model naming helper, validates model-name edits, and adds a delete confirmation modal.
cmd/picoclaw-launcher-tui/internal/ui/channel.go	Removes the “Back” item from the channel menu list (relying on Esc navigation).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cmd/picoclaw-launcher-tui/internal/ui/model.go

Copilot · 2026-03-09T10:17:10Z

cmd/picoclaw-launcher-tui/internal/ui/app.go

+func (s *appState) countChannels() (enabled int, total int) {
+	c := s.config.Channels
+	entries := []bool{
+		c.Telegram.Enabled,
+		c.Discord.Enabled,
+		c.QQ.Enabled,
+		c.MaixCam.Enabled,
+		c.WhatsApp.Enabled,
+		c.Feishu.Enabled,
+		c.DingTalk.Enabled,
+		c.Slack.Enabled,
+		c.Matrix.Enabled,
+		c.LINE.Enabled,
+		c.OneBot.Enabled,
+		c.WeCom.Enabled,
+		c.WeComApp.Enabled,
+	}


countChannels hard-codes the same enabled-channel list that already exists in hasEnabledChannel(). This duplication can easily drift when new channels are added/renamed. Consider deriving both enabled/total from a single shared slice/helper (e.g., have hasEnabledChannel call countChannels, or introduce a method returning the bools).

cmd/picoclaw-launcher-tui/internal/ui/style.go

cmd/picoclaw-launcher-tui/internal/ui/app.go

Copilot · 2026-03-09T10:17:11Z

cmd/picoclaw-launcher-tui/internal/ui/model.go

+		if s.modelNameExists(value, index) {
+			s.showMessage("Duplicate model name", fmt.Sprintf("Model Name '%s' already exists", value))
+			return
+		}


The new “duplicate model name” validation blocks having multiple model_list entries with the same model_name. In this repo, duplicates are explicitly allowed for load balancing (see Config.ValidateModelList / tests), so this change removes a supported configuration capability. Consider removing this check or turning it into a warning/UX hint rather than a hard error.

Suggested change

if s.modelNameExists(value, index) {

s.showMessage("Duplicate model name", fmt.Sprintf("Model Name '%s' already exists", value))

return

}

// Allow duplicate model names for load balancing; duplicates are validated elsewhere.

cmd/picoclaw-launcher-tui/internal/ui/model.go

Copilot · 2026-03-09T10:17:12Z

cmd/picoclaw-launcher-tui/internal/ui/model.go

 			},
 		})
 	}
+	// Add model entry appended at the end so the models map to rows 1..N


This comment says models map to rows 1..N, but with the Back item removed the model rows are now 0..N-1 (and the Add Model row is at N). Update the comment to match the actual indexing to avoid future off-by-one regressions.

Suggested change

// Add model entry appended at the end so the models map to rows 1..N

// Add model entry appended at the end so the models map to rows 0..N-1 (and Add model is at row N)

…ent handling in channel menu

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-09T10:37:53Z

cmd/picoclaw-launcher-tui/internal/ui/model.go

+			Action: func() {
+				newName := s.nextAvailableModelName("new-model")
+				s.addModel(
+					picoclawconfig.ModelConfig{ModelName: newName, Model: "openai/gpt-5.2"},
+				)
+				s.push(
+					fmt.Sprintf("model-%d", len(s.config.ModelList)-1),
+					s.modelForm(len(s.config.ModelList)-1),
+				)


The "Add model" action mutates s.config.ModelList via s.addModel(...) but does not set s.dirty = true. As a result, the user can add a model and then exit without being prompted to apply/save, losing the change. Mark the state dirty (and refresh menus if needed) when adding a model.

Copilot · 2026-03-09T10:37:54Z

cmd/picoclaw-launcher-tui/internal/ui/model.go

+				newName := s.nextAvailableModelName("new-model")
+				s.addModel(
+					picoclawconfig.ModelConfig{ModelName: newName, Model: "openai/gpt-5.2"},
+				)


Same issue as above in the menu refresh path: this "Add Model" action appends to ModelList but doesn’t mark s.dirty = true, so the new entry can be lost on exit without an apply prompt. Set s.dirty (and refresh relevant menus) when adding the new model here too.

Suggested change

)

)

s.dirty = true

refreshModelMenuFromState(menu, s)

Copilot · 2026-03-09T10:37:54Z

cmd/picoclaw-launcher-tui/internal/ui/model.go

+			SetDoneFunc(func(buttonIndex int, buttonLabel string) {
+				s.pages.RemovePage(pageName)
+				if buttonLabel == "Delete" {
+					s.deleteModel(index)


Deleting a model here ultimately only removes it from ModelList and pops the page; it doesn’t mark s.dirty = true. That means a delete can be silently discarded if the user exits without applying/saving. Also consider clearing/updating Agents.Defaults.Model if the deleted model was selected, and refreshing the main/model menus after deletion to avoid stale UI state.

Suggested change

s.deleteModel(index)

s.deleteModel(index)

// Mark configuration as dirty so the deletion is persisted.

s.dirty = true

// If the deleted model was the default, clear the default model reference.

if s.config != nil {

if s.config.Agents.Defaults.Model == model.Name {

s.config.Agents.Defaults.Model = ""

}

}

…d#1271) * fix(tui): fix model selection and enforce unique model_name, also fix model form button highlight * feat(tui): add footer view with navigation instructions and update menu structure * fix(tui): update model selection labels for clarity and consistency * refactor(tui): remove unused rootChannelDescription function * refactor(tui): simplify rootModelDescription and remove unused 'q' event handling in channel menu * fix(tui): keep selected model name updated Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

taorye added 4 commits March 9, 2026 17:59

fix(tui): fix model selection and enforce unique model_name, also fix…

b23ecc0

… model form button highlight

feat(tui): add footer view with navigation instructions and update me…

05b1442

…nu structure

fix(tui): update model selection labels for clarity and consistency

7d39488

refactor(tui): remove unused rootChannelDescription function

76f64a3

Copilot AI review requested due to automatic review settings March 9, 2026 10:13

taorye added the type: enhancement New feature or request label Mar 9, 2026

Copilot started reviewing on behalf of taorye March 9, 2026 10:13 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

taorye and others added 2 commits March 9, 2026 18:29

refactor(tui): simplify rootModelDescription and remove unused 'q' ev…

3a90e19

…ent handling in channel menu

fix(tui): keep selected model name updated

6214f23

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 9, 2026 10:34

Copilot started reviewing on behalf of taorye March 9, 2026 10:34 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

imguoguo approved these changes Mar 9, 2026

View reviewed changes

imguoguo merged commit ead2236 into sipeed:main Mar 9, 2026
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhance model selection and add footer navigation instructions#1271

Enhance model selection and add footer navigation instructions#1271
imguoguo merged 6 commits intosipeed:mainfrom
taorye:main

taorye commented Mar 9, 2026

Uh oh!

CLAassistant commented Mar 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	// Add model entry appended at the end so the models map to rows 1..N
	// Add model entry appended at the end so the models map to rows 0..N-1 (and Add model is at row N)

-				)
+				)
+				s.dirty = true
+				refreshModelMenuFromState(menu, s)

-					s.deleteModel(index)
+					s.deleteModel(index)
+					// Mark configuration as dirty so the deletion is persisted.
+					s.dirty = true
+					// If the deleted model was the default, clear the default model reference.
+					if s.config != nil {
+						if s.config.Agents.Defaults.Model == model.Name {
+							s.config.Agents.Defaults.Model = ""
+						}
+					}

Conversation

taorye commented Mar 9, 2026

📝 Description

🗣️ Type of Change

🤖 AI Code Generation

🔗 Related Issue

📚 Technical Context (Skip for Docs)

🧪 Test Environment

📸 Evidence (Optional)

☑️ Checklist

Uh oh!

CLAassistant commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Mar 9, 2026 •

edited

Loading