Skip to content

fix(skills): retry ClawHub requests on HTTP 429#1135

Merged
afjcjsbx merged 2 commits intosipeed:mainfrom
qs3c:fix/1134-clawhub-429-retry
Mar 5, 2026
Merged

fix(skills): retry ClawHub requests on HTTP 429#1135
afjcjsbx merged 2 commits intosipeed:mainfrom
qs3c:fix/1134-clawhub-429-retry

Conversation

@qs3c
Copy link
Contributor

@qs3c qs3c commented Mar 5, 2026

Summary

  • reuse utils.DoRequestWithRetry for ClawHub search/download HTTP requests
  • remove duplicated retry implementation in ClawHubRegistry
  • keep 429 retry behavior covered by existing ClawHub registry tests
  • document registries.clawhub.auth_token in skills tool config docs

Testing

  • go test ./pkg/skills ./pkg/utils

Closes #1134

@afjcjsbx
Copy link
Collaborator

afjcjsbx commented Mar 5, 2026

good point about adding retry on status_codes 429, but rather than reimplement the client with retry I would use the one already existing in the utils package 🙏

@sipeed-bot sipeed-bot bot added type: bug Something isn't working domain: skill labels Mar 5, 2026
@qs3c
Copy link
Contributor Author

qs3c commented Mar 5, 2026

Thanks for the review. Updated in 536e9ac: removed custom retry implementation in ClawHub registry and switched search/download requests to use utils.DoRequestWithRetry, keeping behavior covered by existing tests.

@CLAassistant
Copy link

CLAassistant commented Mar 5, 2026

CLA assistant check
All committers have signed the CLA.

@afjcjsbx
Copy link
Collaborator

afjcjsbx commented Mar 5, 2026

LGTM!

@afjcjsbx afjcjsbx merged commit 445c32a into sipeed:main Mar 5, 2026
4 checks passed
davidburhans added a commit to davidburhans/picoclaw that referenced this pull request Mar 5, 2026
- Merge pull request sipeed#1135 from qs3c/fix/1134-clawhub-429-retry
- refactor(skills): reuse shared HTTP retry helper
- fix(skills): retry ClawHub requests on 429
@Orgmar
Copy link
Contributor

Orgmar commented Mar 6, 2026

@qs3c Nice work reusing DoRequestWithRetry for ClawHub requests and cleaning up the duplicated retry logic. Keeping things DRY while making sure 429 retries still work properly is solid.

We have a PicoClaw Dev Group on Discord where contributors collaborate and share ideas. If you're interested, send an email to [email protected] with the subject [Join PicoClaw Dev Group] qs3c and we'll get you the invite link!

dj-oyu pushed a commit to dj-oyu/picoclaw that referenced this pull request Mar 8, 2026
fix(skills): retry ClawHub requests on HTTP 429
fishtrees pushed a commit to fishtrees/picoclaw that referenced this pull request Mar 12, 2026
fix(skills): retry ClawHub requests on HTTP 429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: skill type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

skills install may fail with persistent HTTP 429 from ClawHub download endpoint (no Retry-After handling)

4 participants