make gateway aware of config.json change#1129
Closed
cytown wants to merge 2 commits intosipeed:mainfrom
Closed
Conversation
|
|
huaaudio
reviewed
Mar 5, 2026
| github.com/bwmarrin/discordgo v0.29.0 | ||
| github.com/caarlos0/env/v11 v11.3.1 | ||
| github.com/chzyer/readline v1.5.1 | ||
| github.com/fsnotify/fsnotify v1.4.9 |
Collaborator
There was a problem hiding this comment.
If we import fsnotify and filetype purely for the hot reloading of config, the burden of memory & binary size has to be reckoned. In this sense I don't think it is that necessary.
Contributor
Author
There was a problem hiding this comment.
size from 20736608 to 21120112 in x86 macOS. include 32 new commit include this one.
Contributor
Author
There was a problem hiding this comment.
update new PR for remove fsnotify... pls check.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
make gateway command aware of config.json change
🗣️ Type of Change
🤖 AI Code Generation
🔗 Related Issue
📚 Technical Context (Skip for Docs)
🧪 Test Environment
📸 Evidence (Optional)
Click to view Logs/Screenshots
☑️ Checklist