fix(provider) prevent audio as image url#1106
Merged
alexhoshina merged 1 commit intosipeed:mainfrom Mar 5, 2026
Merged
Conversation
alexhoshina
approved these changes
Mar 5, 2026
hyperwd
pushed a commit
to hyperwd/picoclaw
that referenced
this pull request
Mar 5, 2026
…ge-url fix(provider) prevent audio as image url
fishtrees
pushed a commit
to fishtrees/picoclaw
that referenced
this pull request
Mar 12, 2026
…ge-url fix(provider) prevent audio as image url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR fixes a critical bug where transcribed voice messages were causing text-only LLMs (like Zhipu
glm-4.7-flash) to crash with a 404 error.Previously, after the
transcriberprocessed an audio file, the audio reference remained in themsg.Mediaarray. Theopenai_compatprovider then blindly converted all media files intoimage_urlblocks. When sending animage_urlpayload to a text-only model, the API rejected the request entirely.Changes made:
pkg/providers/openai_compat/provider.go(serializeMessages) to strictly filter media types. It now only appendsimage_urlblocks for actual images (strings.HasPrefix(mediaURL, "data:image/")). Transcribed audio is safely ignored at the serialization layer since its content is already injected as text.🗣️ Type of Change
🤖 AI Code Generation
🔗 Related Issue
📚 Technical Context (Skip for Docs)
🧪 Test Environment
glm-4.7-flash📸 Evidence (Optional)
Click to view Logs/Screenshots
Before the fix (Error Log):