Skip to content

Adds notification when there’s a new release available #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kennethormandy wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Adds notification when there’s a new release available #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46202d1
Cleans up package.json ordering for installing dependencies with the CLI
kennethormandy May 7, 2015
3423521
Adds a notification upon package update
kennethormandy May 7, 2015
138ecd8
Improves conditional check for update notification
kennethormandy May 7, 2015
d364f77
Merge branch 'master' into ko-notify
kennethormandy Jul 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/middleware/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ module.exports = [
require("./domain"),
require("./protocol"),
require("./deploy"),
require("./ipaddress")
require("./ipaddress"),
require("./notify")
//require("./log")
]
30 changes: 30 additions & 0 deletions lib/middleware/notify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
var updateNotifier = require("update-notifier");
var helpers = require("./util/helpers");
var isNPM = require("is-npm");
var pkg = require(__dirname + "./../../package.json");

module.exports = function(req, next){
// Checks for available update and returns an instance
var notifier = updateNotifier({
// updateCheckInterval: 1000, // For testing
pkg: pkg
});

if (!process.stdout.isTTY || isNPM || !notifier.update) {
Copy link

@fearphage fearphage Sep 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverse this if for clarity's sake. When the situation is special, do something special.

if (special && case) {
  takeSpecialAction();
}
// always take this action
next();

next();
} else {

helpers
.log(" ┌────────────────────────────────────────┐ ".grey)
.log(" │ ".grey + "A new version of " + "Surge".bold + " is available!" + " │".grey)
.log(" │ ".grey + "Yours: ".grey + "v" + notifier.update.current + " │".grey)
.log(" │ ".grey + "Latest: ".grey + "v" + notifier.update.latest + " │".grey)
.log(" │ │".grey)
.log(" │ ".grey + "Run " + "npm install -g ".green + notifier.update.name.green + " to update." + " │".grey)
.log(" └────────────────────────────────────────┘ ".grey)
.log()
.log()

next();
}
}
13 changes: 8 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,20 @@
"dependencies": {
"du": "0.1.0",
"fstream-ignore": "1.0.2",
"is-npm": "^1.0.0",
"is-domain": "0.0.1",
"moniker": "0.1.2",
"netrc": "0.1.3",
"prompt": "~0.2.14",
"opn": "1.0.1",
"progress": "1.1.8",
"prompt": "~0.2.14",
"read": "1.0.5",
"request": "2.40.0",
"split": "0.3.1",
"surge-ignore": "0.2.0",
"tar": "1.0.0",
"tar.gz": "0.1.1",
"update-notifier": "^0.4.0",
"url-parse-as-address": "1.0.0",
"read": "1.0.5",
"minimist": "1.1.1"
Expand All @@ -26,12 +30,11 @@
},
"license": "ISC",
"main": "./lib/surge.js",
"repository": "sintaxi/surge",
"scripts": {
"test": "mocha test"
},
"repository": {
"type": "git",
"url": "https://github.com/sintaxi/surge.git"
},
"scripts": {
"test": "mocha test"
}
}