fix: bind infinite loop check to clock instance

[SimenB]

Purpose (TL;DR) - mandatory

Failing test from #375 (comment).

By not resetting, the counter is not tied to a specific clock but rather then entire withGlobal.

I'll push a second commit moving the attribute from living in the withGlobal closure to living on the clock object, which I think is more correct

[SimenB]

Pushed a commit that's almost there - interval fails since the timer itself doesn't have an error object - only the last one does. Not sure how to deal with it? A single interval will run forever with runAll without us ever registering an error

[SimenB]

moving this after the check fixes all but the setInterval tests

[SimenB]

@fatso83 I don't know how to deal with setInterval. Ideas?

One quick fix is of course to handle error not being present in getInfiniteLoopError and just return the error created there without trying to get a better trace

[SimenB]

Pushed that latest thing - not ideal, but I don't know how to solve it properly

[fatso83]

This looks fine, but TBH I am just too tired to grok the details of this right now, so I cannot really say something very useful about the .error prop ...

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.10%. Comparing base (85463d9) to head (61cfb60).
⚠️ Report is 148 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files           1        1           
  Lines         611      611           
=======================================
  Hits          575      575           
  Misses         36       36           

Flag	Coverage Δ
unit	94.10% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[fatso83]

Not totally sure what "this" refers to really. The tests or the setInteval function or what.

[SimenB]

tracking of callbacks triggered by setInterval

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[fatso83]

Is this going somewhere? Can I help? Not totally sure what to do between your last commend and Benji's approval.