Skip to content

Improve vertical alignment of the notifier output #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sindresorhus merged 2 commits into from
Aug 16, 2020
+2 −4
Merged

Improve vertical alignment of the notifier output #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00c6b96
Better align the notifier
astorije Jul 24, 2020
3a98928
Fix tests
astorije Jul 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class UpdateNotifier {
chalk().cyan(format(' sudo chown -R $USER:$(id -gn $USER) %s ', xdgBasedir().config));

process.on('exit', () => {
console.error('\n' + boxen()(message, {align: 'center'}));
console.error(boxen()(message, {align: 'center'}));
});
}
}
Expand Down Expand Up @@ -151,7 +151,7 @@ class UpdateNotifier {
borderStyle: 'round'
};

const message = '\n' + boxen()(
const message = boxen()(
pupa()(template, {
packageName: this.packageName,
currentVersion: this.update.current,
Expand Down
2 changes: 0 additions & 2 deletions test/notify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ test('use pretty boxen message by default', t => {
notifier.notify({defer: false, isGlobal: true});

t.is(stripAnsi(errorLogs), `

╭───────────────────────────────────────────────────╮
│ │
│ Update available 0.0.2 → 1.0.0 │
Expand Down Expand Up @@ -83,7 +82,6 @@ test('supports message with placeholders', t => {
});

t.is(stripAnsi(errorLogs), `

╭─────────────────────────────────────────────────────╮
│ │
│ Package Name: update-notifier-tester │
Expand Down