Fix character matching for emoji #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richie Bendall <[email protected]>
Signed-off-by: Richie Bendall <[email protected]>
Contributor
Author
|
@sindresorhus Please review this PR. |
Contributor
Author
|
@sindresorhus Ping! |
Owner
|
There's no need to ping so much. I will get to this when I can. I have a bunch of PRs to review and this is not top priority. |
sindresorhus
changed the title
Signed-off-by: Richie Bendall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights
I extracted Lodash's more comprehensive character matching regex into another module which is now referenced in the code as a drop-in replacement.
I've also removed exports.default in preparation for the next major release.
Breaking Changes
Fixes #1
cc @sindresorhus