Support undefined values for searchParams object - #729
Merged
Conversation
sholladay
requested changes
Sep 2, 2025
|
|
||
| // eslint-disable-next-line unicorn/prevent-abbreviations | ||
| export type SearchParamsOption = SearchParamsInit | Record<string, string | number | boolean> | Array<Array<string | number | boolean>>; | ||
| export type SearchParamsOption = SearchParamsInit | Record<string, string | number | boolean | undefined> | Array<Array<string | number | boolean>>; |
Collaborator
There was a problem hiding this comment.
Shouldn't we add null as an allowed type here?
Owner
Author
There was a problem hiding this comment.
That's intentional. Developers can mistakenly expect null to behave like undefined then and have it serialized to "null" without it being intentional. I think it should be an intentional choice as the result may not be the expected behavior.
Collaborator
There was a problem hiding this comment.
Ok, but I think as any will end up being relatively common and the JS/TS API will seem inconsistent.
|
|
||
| const objectWithNull = { | ||
| cats: 'meow', | ||
| dogs: null as any, |
Collaborator
There was a problem hiding this comment.
I don't see much value in requiring users to as any every null value. Seems like it would just be cumbersome.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #293