Some of the Got issues that could be applied to Ky

[szmarczak]

• Storing request specific context in Got
• Pagination support
• Ambiguous URLs

Also, we could possibly add these hooks:

• beforeRedirect
• beforeRetry
• beforeError

Also see #128 (comment) (mutableDefaults)

[sholladay]

Ky has a json option, whereas Got automatically detects objects in the body option and acts accordingly. Would be nice to make a decision on which one is better and have the same API. I think I lean towards the latter. I guess the idea with the json option was to simplify the implementation, but here we have to check for the case where both body and json were used and if so, throw an error. So maybe it's a wash?

[szmarczak]

Ky has a json option, whereas Got automatically detects objects in the body option an acts accordingly.

Got has a json option too. body is meant for strings, buffers, streams and form-data instances only. This is beacuse we don't know if we should call .toString() or JSON.stringify(...).

[sholladay]

This example may be out of date, then?

[szmarczak]

Indeed. I think @sindresorhus has told me about it some time ago and I forgot to change that :P

[RemyLivewall]

A before error hook would be a nice addition to handle timeouts or specific errors that can be handled in the same way to prevent unnecessary duplication of error handling code.

[cassiechew]

100% agree, adding pagination support would be quite nice.

[sholladay]

I don't think beforeRedirect is actionable here. While browser fetch() technically has a redirect: 'manual' mode, it causes an opaque response to be returned. It's basically useless. There is response.redirected, so we could probably support an afterRedirect hook. But it seems simpler to just check for that in afterResponse anyway.

Request-specific context was released in v1.13.0 via PR #772.

That leaves only pagination from this list.

[sindresorhus]

100% agree, adding pagination support would be quite nice.

Not something I plan built-in in Ky, but see: 2481afd