Skip to content

Put hash right before the last file extension - #245

Merged
sindresorhus merged 1 commit into
sindresorhus:masterfrom
phazei:patch-1
Oct 16, 2018
Merged

Put hash right before the last file extension#245
sindresorhus merged 1 commit into
sindresorhus:masterfrom
phazei:patch-1

Conversation

@phazei

@phazei phazei commented Jun 5, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves #244

@XhmikosR

XhmikosR commented Aug 2, 2018

Copy link
Copy Markdown
Contributor

Ping @sindresorhus

@sindresorhus sindresorhus changed the title Put hash right before file extension Put hash right before the last file extension Oct 16, 2018
@sindresorhus
sindresorhus merged commit de0537f into sindresorhus:master Oct 16, 2018
@XhmikosR

XhmikosR commented Oct 17, 2018

Copy link
Copy Markdown
Contributor

@phazei can you add a test case? It seems this doesn't really fix the issue.

// jquery.fancybox.min.css
filename is: jquery.fancybox.min
extIndex is: 15
filename.slice(0, extIndex): jquery.fancybox
filename.slice(extIndex): .min

@XhmikosR XhmikosR mentioned this pull request Oct 17, 2018
Closed
@XhmikosR

XhmikosR commented Oct 17, 2018

Copy link
Copy Markdown
Contributor

Nevermind, I think I solved it. See #248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phazei @XhmikosR @sindresorhus