Include Marketplace and other unread messages in tray icon number#2133
Merged
Conversation
Contributor
|
This is awesome. I will test this weekend and also open a PR to have the package.json packages updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will loop through all the chat categories (Chats, People, Marketplace, Message Requests, Archive) and extract any numbers in its
ariaLabel. While I don't expect People or Archive to have unread items, this will still loop through them. This is built off of discussion in #2109 with @stkrknds and @sgtcoder.Technically, the
elementReady()only waits for the first element (Chats), but it still seems to work as expected after startup.One strange thing: if you have unread Marketplace messages when Caprine starts up, it won't load this number until Marketplace is selected. But this is an issue with Messenger.com itself, not with Caprine.