Skip to content

Conversation

@ArslanSaleem
Copy link
Collaborator

@ArslanSaleem ArslanSaleem commented Jun 17, 2025

Important

Remove push and pull methods from DataFrame class and update related documentation and tests.

  • Behavior:
    • Remove push and pull methods from DataFrame class in base.py.
    • Remove push command from CLI in main.py.
    • Update CLI to only support pull command for dataset retrieval.
  • Documentation:
    • Remove sections related to push and pull methods from README.md and docs/v3/*.mdx files.
    • Update documentation to reflect changes in data sharing and management.
  • Tests:
    • Remove tests related to push and pull methods from test_dataframe.py and test_pull.py.
    • Update CLI tests in test_cli.py to reflect removal of push command.
    • Remove integration tests related to push and pull in integration_tests directory.

This description was created by Ellipsis for daeceb2. You can customize this summary. It will automatically update as commits are pushed.

@ArslanSaleem ArslanSaleem requested a review from gventuri June 17, 2025 16:14
@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.20%. Comparing base (cb5fecd) to head (daeceb2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1758      +/-   ##
==========================================
- Coverage   91.62%   91.20%   -0.42%     
==========================================
  Files          72       72              
  Lines        2806     2752      -54     
==========================================
- Hits         2571     2510      -61     
- Misses        235      242       +7     
Flag Coverage Δ
unittests 91.20% <100.00%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to daeceb2 in 2 minutes and 30 seconds. Click for details.
  • Reviewed 1052 lines of code in 20 files
  • Skipped 2 files when reviewing.
  • Skipped posting 9 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. README.md:16
  • Draft comment:
    Removed the push/pull usage examples from the platform section. Ensure a migration note is provided for users.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment suggests ensuring a migration note is provided for users, which is a form of asking the author to ensure something is done. This violates the rule against asking the author to ensure something is done.
2. docs/v3/cli.mdx:27
  • Draft comment:
    Push and pull command instructions have been removed from the CLI docs. Verify that users are now guided only to use supported commands.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. docs/v3/getting-started.mdx:142
  • Draft comment:
    Removed the push/pull examples and 'Sharing and collaboration' block to reflect the deprecation of these methods.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, explaining what was done without providing any actionable feedback or suggestions. It doesn't align with the rules for useful comments.
4. docs/v3/share-dataframes.mdx:11
  • Draft comment:
    Updated the share-dataframes documentation to remove push/pull instructions and emphasize platform-based sharing.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative and does not provide any actionable feedback or suggestions for improvement. It simply states what was done in the update, which violates the rule against making purely informative comments.
5. pandasai/cli/main.py:138
  • Draft comment:
    Removed the 'push' command from the CLI. Confirm that only the 'pull' command remains for remote dataset operations.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
6. pandasai/dataframe/base.py:151
  • Draft comment:
    Deprecated push() and pull() methods have been removed from the DataFrame class. Ensure no external references remain.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is informative and suggests ensuring no external references remain, which violates the rule against asking the PR author to ensure something. It doesn't provide a specific code suggestion or ask for a specific test to be written.
7. tests/integration_tests/local_view/test_local_view.py:138
  • Draft comment:
    Removed integration tests for push() and pull() functionality. Confirm that test coverage now only addresses the remaining features.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to confirm that test coverage is sufficient after removing tests, which violates the rule against asking for confirmation or ensuring behavior is intended. It doesn't provide a specific suggestion or point out a specific issue.
8. tests/unit_tests/test_cli.py:194
  • Draft comment:
    Removed push command tests from CLI unit tests. Verify that all removed functionality is no longer inadvertently referenced.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
9. docs/v3/getting-started.mdx:36
  • Draft comment:
    Typographical note: Consider changing the phrase "get your free API key signing up at" to "get your free API key by signing up at" for improved clarity and correctness.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_HXX20H4It7hqtx1X

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@gventuri gventuri merged commit 6bf9240 into main Jun 17, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants