Skip to content

Conversation

@ArslanSaleem
Copy link
Collaborator

@ArslanSaleem ArslanSaleem commented Jan 30, 2025

Important

Update pyproject.toml to adjust dependencies, remove sqlite extra, and increment version to 0.1.5.

  • Dependencies:
    • Move psycopg2-binary, pymysql, and cockroachdb from dev.dependencies to main dependencies with optional flags in pyproject.toml.
    • Remove sqlite from extras in pyproject.toml.
  • Version:
    • Update version from 0.1.4 to 0.1.5 in pyproject.toml.
  • Misc:
    • Adjust build-backend line formatting in pyproject.toml.

This description was created by Ellipsis for 572e628. It will automatically update as commits are pushed.

@ArslanSaleem ArslanSaleem requested a review from gventuri January 30, 2025 15:34
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 572e628 in 29 seconds

More details
  • Looked at 42 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. extensions/connectors/sql/pyproject.toml:21
  • Draft comment:
    The sqlite extra has been removed without explanation or replacement. If this is intentional, consider documenting the change to inform users who might rely on it.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. extensions/connectors/sql/pyproject.toml:4
  • Draft comment:
L4:description = "SQL integration for PandasAI"
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_MDGYKVnWgciupr9m


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.53%. Comparing base (a0b5878) to head (572e628).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1564   +/-   ##
=======================================
  Coverage   82.53%   82.53%           
=======================================
  Files          64       64           
  Lines        2416     2416           
=======================================
  Hits         1994     1994           
  Misses        422      422           
Flag Coverage Δ
unittests 82.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gventuri gventuri merged commit 01bf53e into main Jan 30, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants