remove[BambooVectorstore]: delete bamboo vectorstore completely #1463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to fc0148e in 26 seconds
More details
- Looked at
227lines of code in4files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. pandasai/vectorstores/__init__.py:2
- Draft comment:
Update the comment to reflect that BambooVectorStore has been removed. - Reason this comment was not posted:
Confidence changes required:50%
The import statement for BambooVectorStore has been removed, but the comment should mention that the BambooVectorStore is no longer available.
2. pandasai/vectorstores/__init__.py:2
- Draft comment:
Change 'for training purpose' to 'for training purposes'. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_GhGuA4Hej11E4vQa
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ccbf3c0 in 9 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pandasai/agent/base.py:90
- Draft comment:
The addition ofself._state.vectorstore = vectorstoreseems unrelated to the task of removing BambooVectorStore. Please ensure this change is intentional and relevant to the PR. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_O4lttUVuo0P5n1A4
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Remove
BambooVectorStoreclass and all related references and tests from the codebase.BambooVectorStoreclass frombamboo_vectorstore.py.BambooVectorStoreimport and initialization inbase.py.test_bamboo_vector_store.pyunit tests.BambooVectorStorefrom__all__in__init__.py.This description was created by
for ccbf3c0. It will automatically update as commits are pushed.