Skip to content

Conversation

@deivid-rodriguez
Copy link
Collaborator

@deivid-rodriguez deivid-rodriguez commented Nov 30, 2019

I saw your discussion in #756 (comment) and the following comments, and I think your preference seems to be to commit the lock file to the repo. Since I agree with that, I figure I would contribute that change.

To summarize some ideas about this:

As an extra change, I moved development dependencies to the Gemfile. These dependencies are not used in runtime, they're only used for developing the library, and keeping them in the Gemfile is more flexible. For example, you can point them to git repositories or to local folders, which is something you cannot do inside the gemspec file.

These files no longer exist.
This is more flexible, since you can point to gems from git or path
sources, for example.
Copy link
Collaborator

@PragTob PragTob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on everything, thank you very much 💚 👍 🎉

WhatsApp Image 2019-01-21 at 15 24 38

@PragTob PragTob merged commit 61ca63d into simplecov-ruby:master Nov 30, 2019
@deivid-rodriguez deivid-rodriguez deleted the improve_dev_setup branch November 30, 2019 13:05
PragTob added a commit to simplecov-ruby/simplecov-html that referenced this pull request Dec 5, 2019
PragTob added a commit to simplecov-ruby/simplecov-html that referenced this pull request Dec 5, 2019
PragTob added a commit to simplecov-ruby/simplecov-html that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants