TranscodeAudioFileJob: Replace pipe with tempfile to prevent deadlock#2
Merged
Merged
Conversation
Using a regular file instead of a pipe prevents ffmpeg from blocking indefinitely waiting for the euphony to read -- which it never does until the ffmpeg subprocess exits. Fixes simongoricar#1
Owner
|
Oops, don't mind the CI fail, I cancelled it because I forgot to update |
Owner
|
Hi, I thought about it and looked into it a bit, and it turns out that we can still avoid creating temporary files by using anonymous pipes (see But I think we can still merge this fix for a start until that's done, and we can look into improvements for this on the linked issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a regular file instead of a pipe prevents ffmpeg from blocking indefinitely waiting for the euphony to read -- which it never does until the ffmpeg subprocess exits.
Fixes #1