SilNlpEnv refactoring#1062
Open
benjaminking wants to merge 4 commits intomasterfrom
Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes two major changes to
SilNlpEnv:I should mention that this refactoring is far from the final word on how the environment should be treated. It's a step in the right direction, but in most places where
SilNlpEnvis used, there is further refactoring to do. It is now frequently an argument passed to various functions, and in almost all of these cases, it would be more appropriate to wrap these functions in classes, so that long-lived context information, like the environment, can be provided during object creation, and the request-scoped information can remain as the method parameters. Furthermore, many places in the code should probably not be interacting directly with the environment object, but with a higher-level abstraction (something likeExperimentFileManagerorParatextProject).@TaperChipmunk32, can you take a close look at the onboarding scripts? I had to make several changes to those scripts, but I don't know the right way to test them, so those changes have not been tested.
This change is