Efcache 1.3.2 upgrade with netstandard2.1#44
Merged
silentbobbert merged 2 commits intosilentbobbert:feature/pr_44from Nov 9, 2020
sergevm:efcache-1.3.2-upgrade-with-netstandard2.1
Merged
Efcache 1.3.2 upgrade with netstandard2.1#44silentbobbert merged 2 commits intosilentbobbert:feature/pr_44from sergevm:efcache-1.3.2-upgrade-with-netstandard2.1
silentbobbert merged 2 commits intosilentbobbert:feature/pr_44from
sergevm:efcache-1.3.2-upgrade-with-netstandard2.1
Conversation
added 2 commits
October 22, 2020 08:48
…zation on System.RuntimeType (see moozzyk/EFCache#51) since dotnet core 2. Added target framework netstandard2.1.
silentbobbert
added a commit
that referenced
this pull request
Nov 9, 2020
* Efcache 1.3.2 upgrade with netstandard2.1 (#44) * Added netstandard2.0 target framework. * Upgrade to EFCache v1.3.2, because of broken binary formatter serialization on System.RuntimeType (see moozzyk/EFCache#51) since dotnet core 2. Added target framework netstandard2.1. Co-authored-by: Van Meerbeeck, Serge <[email protected]> * Prepare PR for release Co-authored-by: Ian Robertson <[email protected]> Co-authored-by: sergevm <[email protected]> Co-authored-by: Van Meerbeeck, Serge <[email protected]> Co-authored-by: Ian Robertson <[email protected]>
Owner
|
@sergevm - your PR has been merged and I published a new version of the package to Nuget. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #43
The serialization of EFCache's ColumnMetadata is broken since dotnet core 2, because System.RuntimeType is no longer marked as serializable. EFCache v1.3.2 adds an ISerializable implementation to the ColumnMetadata struct to handle this. That is the main purpose of this PR.
To handle the compatibility warnings in a dotnet core project, I also propose to add a netstandard2.1 target framework.