MainBar: refresh sample rate list when channels popup closes#115
Open
heeen wants to merge 1 commit intosigrokproject:masterfrom
Open
MainBar: refresh sample rate list when channels popup closes#115heeen wants to merge 1 commit intosigrokproject:masterfrom
heeen wants to merge 1 commit intosigrokproject:masterfrom
Conversation
Some drivers (e.g. sipeed-slogic-analyzer) change the available sample rates based on which channels are enabled. Connect the channels popup closed() signal to on_config_changed() so the sample rate dropdown is refreshed after the user toggles channels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closed()signal toon_config_changed()to refresh the sample rate dropdown after toggling channelsProblem
Some drivers change available sample rates based on enabled channel count (e.g. sipeed-slogic-analyzer: 200MHz@16ch, 400MHz@8ch, 800MHz@4ch). The sample rate dropdown was not refreshed after toggling channels, so users had to manually change the rate to trigger a re-query.
Fix
When the channels popup closes, call
on_config_changed()which callscommit_sample_rate()→update_sample_rate_selector(), refreshing the rate dropdown.Test plan