rdtech-rd: Fix <inf> samples for RD6006#283
Open
DidierA wants to merge 1 commit intosigrokproject:masterfrom
Open
rdtech-rd: Fix <inf> samples for RD6006#283DidierA wants to merge 1 commit intosigrokproject:masterfrom
DidierA wants to merge 1 commit intosigrokproject:masterfrom
Conversation
Author
|
@mdjurfeldt I would appreciate feedback on this, does this fix seem appropriate? Can you test on your RD6012P if it does not break ? |
Contributor
|
@DidierA Hi, looking at the code, I don't think it should break. I can try to test it during the coming few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my RD6006, no current or voltage value where available: they all returned
inf.I tracked the bug to the current and voltage multipliers being 0, because they were not initialized.
This was due to the test in
rdtech_dps_update_rangefor multiple ranges, which returns false in this case, causing the function to return without callingrdtech_dps_update_multipliers.With this patch, the multipliers are initialized, and both sigrok-cli and smuview obtain the correct values.
The
devc->model->n_ranges <= 1test had been introduced with PR #205 to support RD6012P. I do not own any other RD6xxx power supply, so I could only test this with RD6006.Example run:
Before this fix:
After this fix: