Skip to content

Disable log color when running in non-interactive mode #7240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 3 commits into from
Apr 4, 2025
Merged

Disable log color when running in non-interactive mode #7240

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ace4a4
Disable log color when running in non-interactive mode
macladson Apr 1, 2025
5116159
Merge branch 'unstable' into tracing-remove-ansi-when-noninteractive
macladson Apr 3, 2025
0e12793
Merge branch 'unstable' into tracing-remove-ansi-when-noninteractive
macladson Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lighthouse/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ use lighthouse_version::VERSION;
use logging::{build_workspace_filter, crit, MetricsLayer};
use malloc_utils::configure_memory_allocator;
use std::backtrace::Backtrace;
use std::io::IsTerminal;
use std::path::PathBuf;
use std::process::exit;
use std::sync::LazyLock;
Expand Down Expand Up @@ -521,10 +522,15 @@ fn run<E: EthSpec>(

let log_format = matches.get_one::<String>("log-format");

let log_color = matches
.get_one::<bool>("log-color")
.copied()
.unwrap_or(true);
let log_color = if std::io::stdin().is_terminal() {
matches
.get_one::<bool>("log-color")
.copied()
.unwrap_or(true)
} else {
// Disable color when in non-interactive mode.
false
};

let logfile_color = matches.get_flag("logfile-color");

Expand Down
Loading