Simplify Validator Creation and Align with Spec #6515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethDreamer
force-pushed
the
add_validator_to_registry
branch
from
7bed48b to
38d24a6
Compare
Member
Author
|
I noticed this while reviewing: which was originally difficult to follow because of how convoluted our approach is getting. |
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 6eaa370 |
5 tasks
chong-he
pushed a commit
to chong-he/lighthouse
that referenced
this pull request
Nov 26, 2024
* Simplify Validator Creation and Align with Spec * clippy * Bug Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
The current code for adding new validators doesn't align well with the spec and it's getting increasingly convoluted as changes are made in different forks. This simplifies it and brings it into much closer alignment with the spec.