Merged
Conversation
michaelsproul
added
ready-for-review
Member
|
Nice! Just thought it would be nice to update the downgrade example to v4+ to match the table above. I have created a PR here: michaelsproul#6 Other than that, all good |
* update downgrade example * Add period
michaelsproul
commented
Dec 7, 2023
Member
Author
|
Thanks for the review CK! I'll do one more update then we can merge |
jimmygchen
added
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
--broadcastflag for the VC (introduced in Broadcast various requests as per #4684 #4920).Additional Info
My text editor stripped some trailing whitespace, which I know is sometimes significant in markdown, although on this occasion it doesn't seem to have affected the render.