Merged
Conversation
michaelsproul
added
ready-for-review
jimmygchen
added
ready-for-merge
Contributor
|
Sorry, that's from my PR! I just compiled a new version of the unstable branch with this fix and deployed it to our infra and it indeed removes the warning message highlighted by Michael. Also I have loaded the validator monitor with 15k of pub keys on Goerli for a short period of time, the time to have enough data to update the new charts in the metrics repository according to the latest version of #4731. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Without this patch Lighthouse frequently logs:
The reason is that
self.indicescontains indices for all validators, whileself.pubkeysonly contains pubkeys for monitored validators. The log occurs when a non-monitored validator misses a block.Bug was introduced in #4731