[Merged by Bors] - Add commmand for pruning states#4835
Closed
jimmygchen wants to merge 19 commits intosigp:unstablefrom
Closed
[Merged by Bors] - Add commmand for pruning states#4835jimmygchen wants to merge 19 commits intosigp:unstablefrom
jimmygchen wants to merge 19 commits intosigp:unstablefrom
Conversation
7 tasks
jimmygchen
force-pushed
the
prune-states
branch
from
e13b9de to
cd0d4e7
Compare
jimmygchen
added
work-in-progress
bors bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
## Issue Addressed Fixes #4697. This also unblocks the state pruning PR (#4835). Because self healing breaks if state pruning is applied to a database with missing block roots. ## Proposed Changes - Fill in the missing block roots between last restore point slot and split slot when upgrading to latest database version.
# Conflicts: # beacon_node/beacon_chain/tests/store_tests.rs # beacon_node/store/src/hot_cold_store.rs # beacon_node/store/src/lib.rs # database_manager/src/lib.rs
jimmygchen
commented
Oct 30, 2023
# Conflicts: # beacon_node/store/src/lib.rs # beacon_node/store/src/memory_store.rs # database_manager/src/lib.rs
jimmygchen
force-pushed
the
prune-states
branch
from
a770ef6 to
ddfe53e
Compare
jimmygchen
added
ready-for-review
jimmygchen
commented
Nov 1, 2023
jimmygchen
commented
Nov 1, 2023
jimmygchen
commented
Nov 1, 2023
michaelsproul
added
ready-for-merge
Member
|
I added and removed a backwards-incompat label because I thought we'd broken the bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
## Issue Addressed Closes #4481. (Continuation of #4648) ## Proposed Changes - [x] Add `lighthouse db prune-states` - [x] Make it work - [x] Ensure block roots are handled correctly (to be addressed in 4735) - [x] Check perf on mainnet/Goerli/Gnosis (takes a few seconds max) - [x] Run block root healing logic (#4875 ) at the beginning - [x] Add some tests - [x] Update docs - [x] Add `--freezer` flag and other improvements to `lighthouse db inspect` Co-authored-by: Michael Sproul <[email protected]> Co-authored-by: Jimmy Chen <[email protected]> Co-authored-by: Michael Sproul <[email protected]>
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #4481.
(Continuation of #4648)
Proposed Changes
lighthouse db prune-states--freezerflag and other improvements tolighthouse db inspect