[Merged by Bors] - Fix block backfill with genesis skip slots#4820
Closed
michaelsproul wants to merge 1 commit intosigp:unstablefrom
Closed
[Merged by Bors] - Fix block backfill with genesis skip slots#4820michaelsproul wants to merge 1 commit intosigp:unstablefrom
michaelsproul wants to merge 1 commit intosigp:unstablefrom
Conversation
michaelsproul
added
bug
michaelsproul
force-pushed
the
fix-state-reconstruction
branch
from
b6a78e2 to
a974faf
Compare
paulhauner
approved these changes
Oct 27, 2023
Member
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
I spent a while getting my head across this and it looks good.
Nice one!
michaelsproul
added
ready-for-merge
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
## Issue Addressed Closes #4817. ## Proposed Changes - Fill in the linear block roots array between 0 and the slot of the first block (e.g. slots 0 and 1 on Holesky). - Backport the `--freezer`, `--skip` and `--limit` options for `lighthouse db inspect` from tree-states. This allows us to easily view the database corruption of 4817 using `lighthouse db inspect --network holesky --freezer --column bbr --output values --limit 2`. - Backport the `iter_column_from` change and `MemoryStore` overhaul from tree-states. These are required to enable `lighthouse db inspect`. - Rework `freezer_upper_limit` to allow state lookups for slots below the `state_lower_limit`. Currently state lookups will fail until state reconstruction completes entirely. There is a new regression test for the main bug, but no test for the `freezer_upper_limit` fix because we don't currently support running state reconstruction partially (see #3026). This will be fixed once we merge `tree-states`! In lieu of an automated test, I've tested manually on a Holesky node while it was reconstructing. ## Additional Info Users who backfilled Holesky to slot 0 (e.g. using `--reconstruct-historic-states`) need to either: - Re-sync from genesis. - Re-sync using checkpoint sync and the changes from this PR. Due to the recency of the Holesky genesis, writing a custom pass to fix up broken databases (which would require its own thorough testing) was deemed unnecessary. This is the primary reason for this PR being marked `backwards-incompat`. This will create few conflicts with Deneb, which I've already resolved on `tree-states-deneb` and will be happy to backport to Deneb once this PR is merged to unstable.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
## Issue Addressed Closes #4817. ## Proposed Changes - Fill in the linear block roots array between 0 and the slot of the first block (e.g. slots 0 and 1 on Holesky). - Backport the `--freezer`, `--skip` and `--limit` options for `lighthouse db inspect` from tree-states. This allows us to easily view the database corruption of 4817 using `lighthouse db inspect --network holesky --freezer --column bbr --output values --limit 2`. - Backport the `iter_column_from` change and `MemoryStore` overhaul from tree-states. These are required to enable `lighthouse db inspect`. - Rework `freezer_upper_limit` to allow state lookups for slots below the `state_lower_limit`. Currently state lookups will fail until state reconstruction completes entirely. There is a new regression test for the main bug, but no test for the `freezer_upper_limit` fix because we don't currently support running state reconstruction partially (see #3026). This will be fixed once we merge `tree-states`! In lieu of an automated test, I've tested manually on a Holesky node while it was reconstructing. ## Additional Info Users who backfilled Holesky to slot 0 (e.g. using `--reconstruct-historic-states`) need to either: - Re-sync from genesis. - Re-sync using checkpoint sync and the changes from this PR. Due to the recency of the Holesky genesis, writing a custom pass to fix up broken databases (which would require its own thorough testing) was deemed unnecessary. This is the primary reason for this PR being marked `backwards-incompat`. This will create few conflicts with Deneb, which I've already resolved on `tree-states-deneb` and will be happy to backport to Deneb once this PR is merged to unstable.
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #4817.
Proposed Changes
--freezer,--skipand--limitoptions forlighthouse db inspectfrom tree-states. This allows us to easily view the database corruption of 4817 usinglighthouse db inspect --network holesky --freezer --column bbr --output values --limit 2.iter_column_fromchange andMemoryStoreoverhaul from tree-states. These are required to enablelighthouse db inspect.freezer_upper_limitto allow state lookups for slots below thestate_lower_limit. Currently state lookups will fail until state reconstruction completes entirely.There is a new regression test for the main bug, but no test for the
freezer_upper_limitfix because we don't currently support running state reconstruction partially (see #3026). This will be fixed once we mergetree-states! In lieu of an automated test, I've tested manually on a Holesky node while it was reconstructing.Additional Info
Users who backfilled Holesky to slot 0 (e.g. using
--reconstruct-historic-states) need to either:Due to the recency of the Holesky genesis, writing a custom pass to fix up broken databases (which would require its own thorough testing) was deemed unnecessary. This is the primary reason for this PR being marked
backwards-incompat.This will create few conflicts with Deneb, which I've already resolved on
tree-states-deneband will be happy to backport to Deneb once this PR is merged to unstable.