Skip to content

Standard Liveness Endpoint #4539

Closed
Gua00va wants to merge 6 commits intosigp:unstablefrom
Gua00va:liveness-endpoint
Closed

Standard Liveness Endpoint #4539
Gua00va wants to merge 6 commits intosigp:unstablefrom
Gua00va:liveness-endpoint

Conversation

@Gua00va
Copy link
Contributor

@Gua00va Gua00va commented Jul 25, 2023

Issue Addressed

Solves #4522

Proposed Changes

Validator Client now uses standard liveness endpoint /eth/v1/validator/liveness/{epoch} implemented here #4343

@jimmygchen jimmygchen added val-client Relates to the validator client binary ready-for-review The code is ready for review labels Jul 25, 2023
@Gua00va
Copy link
Contributor Author

Gua00va commented Jul 28, 2023

@jimmygchen , I think because #4343 is not yet merged into unstable, so the endpoint is throwing a 404 error.

@paulhauner
Copy link
Member

I think because #4343 is not yet merged into unstable

I've just triggered bors on #4343, so hopefully it'll merge in the next couple of hours.

@paulhauner
Copy link
Member

#4343 has merged and there's a little conflict here now 🙏

@paulhauner paulhauner self-assigned this Jul 31, 2023
@paulhauner paulhauner added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jul 31, 2023
@Gua00va
Copy link
Contributor Author

Gua00va commented Jul 31, 2023

@paulhauner , I've fixed the conflict. Should work now !!

@jimmygchen jimmygchen added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jul 31, 2023
@paulhauner
Copy link
Member

Thanks for fixing the conflicts! We have some unhappy tests now though :( Feel free to fix at your leisure ☺️

@paulhauner paulhauner added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Aug 2, 2023
@paulhauner paulhauner added v4.4.1 ETA August 2023 backwards-incompat Backwards-incompatible API change labels Aug 21, 2023
@paulhauner
Copy link
Member

paulhauner commented Aug 21, 2023

Hey @Gua00va, we're hoping to include this in v4.4.0 which means we'd need to have this merged this week (the week of the 21st).

If you'd like to fix up the test compile errors, please go ahead! If you don't have the time to finish it up (which is totally OK), just let me know and we'll finish it up.

If I don't hear from you I'll probably end up just pushing some fixes to this branch ☺️

@Gua00va
Copy link
Contributor Author

Gua00va commented Aug 23, 2023

Hey @Gua00va, we're hoping to include this in v4.4.0 which means we'd need to have this merged this week (the week of the 21st).

If you'd like to fix up the test compile errors, please go ahead! If you don't have the time to finish it up (which is totally OK), just let me know and we'll finish it up.

If I don't hear from you I'll probably end up just pushing some fixes to this branch ☺️

I will try to complete this in a day or two

@paulhauner
Copy link
Member

I'm thinking that we push this to the next release. It'll take the urgency off and there's also merits to delaying it to the next release (see comments in #4522).

So no rush on this one @Gua00va 🙏

@paulhauner paulhauner added v4.5.0 ETA Q4 2023 and removed v4.4.1 ETA August 2023 labels Aug 24, 2023
@paulhauner paulhauner added v4.6.0 ETA Q1 2024 and removed v4.5.0 ETA Q4 2023 labels Sep 20, 2023
@Gua00va
Copy link
Contributor Author

Gua00va commented Oct 16, 2023

@paulhauner, The tests should work fine now. Sorry for the delay !

@Gua00va Gua00va closed this Oct 17, 2023
@michaelsproul michaelsproul reopened this Oct 17, 2023
@michaelsproul
Copy link
Member

@Gua00va Did you mean to close this?

@Gua00va
Copy link
Contributor Author

Gua00va commented Oct 17, 2023

@Gua00va Did you mean to close this?

Yes. I am working on it in a seperate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backwards-incompat Backwards-incompatible API change v4.6.0 ETA Q1 2024 val-client Relates to the validator client binary waiting-on-author The reviewer has suggested changes and awaits thier implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants