[Merged by Bors] - Implement expected withdrawals endpoint#4390
Closed
eserilev wants to merge 33 commits intosigp:unstablefrom
Closed
[Merged by Bors] - Implement expected withdrawals endpoint#4390eserilev wants to merge 33 commits intosigp:unstablefrom
eserilev wants to merge 33 commits intosigp:unstablefrom
Conversation
…plement-expected-withdrawls-endpoint
michaelsproul
changed the title
jimmygchen
reviewed
Jun 20, 2023
jimmygchen
reviewed
Jun 20, 2023
jimmygchen
reviewed
Jun 20, 2023
jimmygchen
reviewed
Jun 20, 2023
jimmygchen
reviewed
Jun 20, 2023
jimmygchen
reviewed
Jun 20, 2023
jimmygchen
reviewed
Jun 20, 2023
Member
|
@eserilev thanks for this! I've added a few comments but overall looks great to me 👍 |
jimmygchen
added
HTTP-API
waiting-on-author
…plement-expected-withdrawls-endpoint
jimmygchen
added
ready-for-review
michaelsproul
added
the
waiting-on-author
…plement-expected-withdrawls-endpoint
Member
Author
|
thanks! should be ready for another review |
Member
|
@eserilev changes look great! I've triggered another CI run and looks like |
jimmygchen
added a commit
to jimmygchen/lighthouse
that referenced
this pull request
Aug 23, 2023
Member
Author
|
whoops, that should be resolved now |
jimmygchen
added
ready-for-review
jimmygchen
added a commit
to jimmygchen/lighthouse
that referenced
this pull request
Aug 23, 2023
jimmygchen
added a commit
to jimmygchen/lighthouse
that referenced
this pull request
Aug 23, 2023
jimmygchen
approved these changes
Aug 24, 2023
Member
jimmygchen
left a comment
jimmygchen
left a comment
There was a problem hiding this comment.
Looks great, thank you! 😃
The cargo audit CI failure is not related to this PR, and will be addressed in #4651.
jimmygchen
added
ready-for-merge
michaelsproul
approved these changes
Aug 24, 2023
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 24, 2023
## Issue Addressed [#4029](#4029) ## Proposed Changes implement expected_withdrawals HTTP API per the spec ethereum/beacon-APIs#304 ## Additional Info
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Aug 24, 2023
## Issue Addressed [#4029](#4029) ## Proposed Changes implement expected_withdrawals HTTP API per the spec ethereum/beacon-APIs#304 ## Additional Info
Member
|
bors r- |
|
Canceled. |
bors bot
pushed a commit
that referenced
this pull request
Aug 24, 2023
## Issue Addressed [#4029](#4029) ## Proposed Changes implement expected_withdrawals HTTP API per the spec ethereum/beacon-APIs#304 ## Additional Info
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
[sigp#4029](sigp#4029) implement expected_withdrawals HTTP API per the spec ethereum/beacon-APIs#304
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
[sigp#4029](sigp#4029) implement expected_withdrawals HTTP API per the spec ethereum/beacon-APIs#304
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#4029
Proposed Changes
implement expected_withdrawals HTTP API per the spec
ethereum/beacon-APIs#304
Additional Info