Skip to content

Fix deneb doppelganger tests#4124

Merged
realbigsean merged 26 commits intosigp:deneb-free-blobsfrom
pawanjay176:fix-deneb-dg
Apr 26, 2023
Merged

Fix deneb doppelganger tests#4124
realbigsean merged 26 commits intosigp:deneb-free-blobsfrom
pawanjay176:fix-deneb-dg

Conversation

@pawanjay176
Copy link
Copy Markdown
Member

@pawanjay176 pawanjay176 commented Mar 23, 2023

Issue Addressed

N/A

Proposed Changes

Fixes doppelganger scripts. Also makes the code compile by adding an unimplemented block that should be resolved in #4092

@pawanjay176 pawanjay176 changed the title Fix deneb dg Fix deneb doppelganger tests Mar 23, 2023
@pawanjay176 pawanjay176 added the ready-for-review The code is ready for review label Mar 23, 2023
@pawanjay176
Copy link
Copy Markdown
Member Author

Hoping this last run should pass CI 🤞

- name: Install ganache
run: npm install ganache@latest --global

- name: Install geth
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @atokama. We are using this for testing for 4844 specific stuff. This might not get merged for quite some time to the main branch. We have another PR #3807 where we should be ideally adding this and updating the docs for building post merge local testnets. Haven't been able to get around to that yet though 😅

@pawanjay176
Copy link
Copy Markdown
Member Author

Update: the failure scenario is not working for some reason despite logs indicating it should. Still checking it out

@divagant-martian
Copy link
Copy Markdown
Contributor

An update from inner talks. This is failing due to an expected/correct peer scoring event (peer is being banned). Work on #4135 should unblock this


# Proposer score boost percentage
PROPOSER_SCORE_BOOST=40
PROPOSER_SCORE_BOOST=70
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@realbigsean realbigsean merged commit cbe4880 into sigp:deneb-free-blobs Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deneb ready-for-review The code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants