[Merged by Bors] - Customisable shuffling cache size #4081
Closed
AgeManning wants to merge 16 commits intosigp:unstablefrom
Closed
[Merged by Bors] - Customisable shuffling cache size #4081AgeManning wants to merge 16 commits intosigp:unstablefrom
AgeManning wants to merge 16 commits intosigp:unstablefrom
Conversation
AgeManning
added
ready-for-review
michaelsproul
requested changes
Mar 17, 2023
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Looks correct, I just had a few stylistic/testing nitpicks
It would be good to add two CLI regression tests in lighthouse/tests/beacon_node.rs, testing the default value and the value after applying the flag (should also use run_with_zero_port for these tests).
michaelsproul
added
waiting-on-author
Co-authored-by: Michael Sproul <micsproul@gmail.com>
AgeManning
added
ready-for-review
Member
|
@AgeManning I just pushed a commit to optimise the regular case (reading from the head state) to remove the I also fixed the indentation of those format strings |
michaelsproul
approved these changes
Mar 21, 2023
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
This PR enables the user to adjust the shuffling cache size.
This is useful for some HTTP API requests which require re-computing old shufflings. This PR currently optimizes the
beacon/states/{state_id}/committees HTTP API by first checking the cache before re-building shuffling.
If the shuffling is set to a non-default value, then the HTTP API request will also fill the cache when as it constructs new shufflings.
If the CLI flag is not present or the value is set to the default of 16 the default behaviour is observed.
Co-authored-by: Michael Sproul <michael@sigmaprime.io>
michaelsproul
added
ready-for-merge
Member
|
lets do a batch bors r- |
|
Canceled. |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
This PR enables the user to adjust the shuffling cache size.
This is useful for some HTTP API requests which require re-computing old shufflings. This PR currently optimizes the
beacon/states/{state_id}/committees HTTP API by first checking the cache before re-building shuffling.
If the shuffling is set to a non-default value, then the HTTP API request will also fill the cache when as it constructs new shufflings.
If the CLI flag is not present or the value is set to the default of 16 the default behaviour is observed.
Co-authored-by: Michael Sproul <michael@sigmaprime.io>
|
Pull request successfully merged into unstable. Build succeeded:
|
bors
bot
changed the title
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
This PR enables the user to adjust the shuffling cache size.
This is useful for some HTTP API requests which require re-computing old shufflings. This PR currently optimizes the
beacon/states/{state_id}/committees HTTP API by first checking the cache before re-building shuffling.
If the shuffling is set to a non-default value, then the HTTP API request will also fill the cache when as it constructs new shufflings.
If the CLI flag is not present or the value is set to the default of 16 the default behaviour is observed.
Co-authored-by: Michael Sproul <michael@sigmaprime.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the user to adjust the shuffling cache size.
This is useful for some HTTP API requests which require re-computing old shufflings. This PR currently optimizes the
beacon/states/{state_id}/committees HTTP API by first checking the cache before re-building shuffling.
If the shuffling is set to a non-default value, then the HTTP API request will also fill the cache when as it constructs new shufflings.
If the CLI flag is not present or the value is set to the default of 16 the default behaviour is observed.