Store downloaded payloads if pruning disabled#3754
Closed
michaelsproul wants to merge 1 commit intosigp:unstablefrom
Closed
Store downloaded payloads if pruning disabled#3754michaelsproul wants to merge 1 commit intosigp:unstablefrom
michaelsproul wants to merge 1 commit intosigp:unstablefrom
Conversation
michaelsproul
force-pushed
the
store-payloads-on-demand
branch
from
0f9c421 to
acae43e
Compare
Member
Author
|
This performed quite badly in practice: it took a long time to download the payloads, and coverage was patchy. If we want to revisit this I think storing payloads of blocks during backfill would work better. It may not be necessary with the new efficient payload reconstruction landing in #4028. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Introduce another stop-gap for payload pruning while we wait for bulk payload APIs – store the downloaded payloads in the database to prevent redownloading. Credit to @paulhauner for the idea.
Additional Info
Needs some more performance testing before it's ready for review.