Update cross to install protoc#3546
Merged
AgeManning merged 1 commit intosigp:libp2p-v0.47.0-upgradefrom Sep 7, 2022
Merged
Conversation
divagant-martian
requested review from
AgeManning,
michaelsproul and
paulhauner
5 tasks
AgeManning
approved these changes
Sep 7, 2022
Member
AgeManning
left a comment
AgeManning
left a comment
There was a problem hiding this comment.
Seems fine to me. I guess scripts is fine.
michaelsproul
approved these changes
Sep 7, 2022
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
I think this is the cleanest approach, well done!
divagant-martian
added a commit
to divagant-martian/lighthouse
that referenced
this pull request
Mar 14, 2023
divagant-martian
added a commit
to divagant-martian/lighthouse
that referenced
this pull request
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
updates cross routines to deal with installing protoc
Proposed Changes
use custom dockerfiles for this
Additional Info
If you have a better location for the scripts or another alternative, happy to hear them.
I ended up with dockerfiles to deal with the
PROTOCenv variable, since it can't be set from the pre build scripts and would otherwise need to be passed from the calling shell. This way, we can keep using cross as alwaysNOTE that this is against the
libp2p-v0.47.0-upgradebranch where I've been doing incremental PRs for the upgrade