[Merged by Bors] - Update discv5#3171
Closed
divagant-martian wants to merge 2 commits intosigp:unstablefrom
Closed
[Merged by Bors] - Update discv5#3171divagant-martian wants to merge 2 commits intosigp:unstablefrom
divagant-martian wants to merge 2 commits intosigp:unstablefrom
Conversation
divagant-martian
force-pushed
the
update-discv5
branch
from
41440a0 to
ee801b5
Compare
divagant-martian
force-pushed
the
update-discv5
branch
2 times, most recently
from
ca9a956 to
d990d9f
Compare
Member
|
Bumping this. @sean - it looks like Alex's repo is causing a bunch of pain for us to maintain. Is it correct that we are only using his deps for testing? |
Member
|
@AgeManning Could we hack in our forks of the deps using a top-level (btw you tagged some rando Sean, our Sean is @realbigsean 🤣 ) |
divagant-martian
added
ready-for-review
Contributor
Author
|
@AgeManning @michaelsproul alex helped me upgrading his deps and this should be ready now |
progress make versions work more progress update breaking deps restore locked versions fix tests
divagant-martian
force-pushed
the
update-discv5
branch
from
95e3434 to
b13a2ae
Compare
Contributor
Author
|
@AgeManning rebased and squashed so that the diff makes sense now, but I see I have two TODOs that need your input |
Member
|
@divagant-martian - Think we just throw errors. IIRC we handle the error cases fairly gracefully. |
Contributor
Author
|
friendly ping @AgeManning |
AgeManning
approved these changes
Oct 21, 2022
Member
AgeManning
left a comment
AgeManning
left a comment
There was a problem hiding this comment.
This looks good to me. Ready to merge, when release schedule allows
AgeManning
added
ready-for-merge
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 28, 2022
## Issue Addressed Updates discv5 Pending on - [x] #3547 - [x] Alex upgrades his deps ## Proposed Changes updates discv5 and the enr crate. The only relevant change would be some clear indications of ipv4 usage in lighthouse ## Additional Info Functionally, this should be equivalent to the prev version. As draft pending a discv5 release
|
Build failed: |
Member
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Oct 28, 2022
## Issue Addressed Updates discv5 Pending on - [x] #3547 - [x] Alex upgrades his deps ## Proposed Changes updates discv5 and the enr crate. The only relevant change would be some clear indications of ipv4 usage in lighthouse ## Additional Info Functionally, this should be equivalent to the prev version. As draft pending a discv5 release
macladson
pushed a commit
to macladson/lighthouse
that referenced
this pull request
Jan 5, 2023
## Issue Addressed Updates discv5 Pending on - [x] sigp#3547 - [x] Alex upgrades his deps ## Proposed Changes updates discv5 and the enr crate. The only relevant change would be some clear indications of ipv4 usage in lighthouse ## Additional Info Functionally, this should be equivalent to the prev version. As draft pending a discv5 release
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed Updates discv5 Pending on - [x] sigp#3547 - [x] Alex upgrades his deps ## Proposed Changes updates discv5 and the enr crate. The only relevant change would be some clear indications of ipv4 usage in lighthouse ## Additional Info Functionally, this should be equivalent to the prev version. As draft pending a discv5 release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Updates discv5
Pending on
Proposed Changes
updates discv5 and the enr crate. The only relevant change would be some clear indications of ipv4 usage in lighthouse
Additional Info
Functionally, this should be equivalent to the prev version.
As draft pending a discv5 release