wire up everything #109
Merged
wire up everything #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- consistently use the same `OperatorId` if not known - really only store own clusters in `clusters`
Zacholme7
reviewed
Jan 20, 2025
Zacholme7
reviewed
Jan 20, 2025
Member
|
small comments, gj otherwise! |
- `wss` -> `ws` in default EL URL - fix slot check for validator load - correctly decode decrypted keys - wait for historical sync to finish before starting duties
Zacholme7
reviewed
Jan 21, 2025
Zacholme7
reviewed
Jan 21, 2025
Member
|
lgtm! |
This was referenced Jan 23, 2025
Member
Author
|
Kingy, can we please merge this? 🥺 @jking-aus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Additional Info
🎉 🎉 🎉
There is some room for optimisation/alignment between the components, but we can leave that for later.