This repository was archived by the owner on Mar 4, 2021. It is now read-only.
feat(commits): list commits since a commitish#2
Merged
sidvishnoi merged 6 commits intomasterfrom Oct 14, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For https://github.com/w3c/respec/issues/1724
The commits are listed in same order as regular
git log.How the caching works? Without the cache, we get the
since(date) for given commitish.After fetching once, we set the
sinceto the date of currentHEAD. With cache, we start the search from the newsincedate, instead of fromref's.Caching benefits (fetching last 504 commits from a repository):
➜ node commits.js Failed to load cache: gh/commits. # timestamp # of records fetched 1570788384931 100 1570788386215 100 1570788387373 100 1570788388495 100 1570788389544 100 1570788390002 4 ➜ node commits.js 1570788394641 504 1570788395097 0